Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't use std abs_diff, put it in test_utils instead, run tests with msrv in action #596

Merged
merged 2 commits into from
Dec 13, 2024
Merged

don't use std abs_diff, put it in test_utils instead, run tests with msrv in action #596

merged 2 commits into from
Dec 13, 2024
+43 −3

Conversation

nicklan
Copy link
Collaborator

@nicklan nicklan commented Dec 13, 2024 •
edited
Loading

What changes are proposed in this pull request?

  • create an abs_diff function in test_utils (same code as in std)
  • use that in the two places we wanted it instead
  • also add a workflow to make sure that we can always compile against msrv

How was this change tested?

  • Existing tests pass
  • New workflow passes

@nicklan nicklan changed the title don't use std abs_diff, put it in test_utils instead don't use std abs_diff, put it in test_utils instead, build tests with msrv Dec 13, 2024
zachschuermann
zachschuermann approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks LGTM! (blocking 0.6 release on this PR)

@nicklan nicklan changed the title don't use std abs_diff, put it in test_utils instead, build tests with msrv don't use std abs_diff, put it in test_utils instead, run tests with msrv in action Dec 13, 2024
@nicklan nicklan mentioned this pull request Dec 13, 2024
Closed
@nicklan nicklan merged commit 71deaa3 into delta-io:main Dec 13, 2024
18 of 19 checks passed
scovich
scovich reviewed Dec 13, 2024
View reviewed changes
test-utils/src/lib.rs
@@ -106,3 +106,13 @@ pub fn into_record_batch(engine_data: Box<dyn EngineData>) -> RecordBatch {
.unwrap()
.into()
}

/// We implement abs_diff here so we don't have to bump our msrv.
/// TODO: Remove and use std version when msrv >= 1.81.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a tracking issue for this so we don't forget?
(really it would be neat if rust had a way to annotate these sorts of workarounds, so they start failing once MSRV bumps)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#598

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachschuermann zachschuermann zachschuermann approved these changes

@scovich scovich scovich left review comments

@OussamaSaoudi-db OussamaSaoudi-db OussamaSaoudi-db approved these changes

@rtyler rtyler rtyler approved these changes

Assignees

@nicklan nicklan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicklan @rtyler @scovich @zachschuermann @OussamaSaoudi-db